Skip to content

Conversation

@jdufresne
Copy link
Contributor

After initializing JSDOM, it will always have a non-null window property. There is no need to check it.

Summary

Towards reducing unreachable code and simplifying the implementation.

Test plan

Project's test suite and type checking.

After initializing JSDOM, it will always have a non-null window
property. There is no need to check it.
@netlify
Copy link

netlify bot commented Jan 4, 2026

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 86a9ff8
🔍 Latest deploy log https://app.netlify.com/projects/jestjs/deploys/695a80d59cfe3f00086a6c60
😎 Deploy Preview https://deploy-preview-15927--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 4, 2026

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@15927

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@15927

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@15927

create-jest

npm i https://pkg.pr.new/create-jest@15927

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@15927

expect

npm i https://pkg.pr.new/expect@15927

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@15927

jest

npm i https://pkg.pr.new/jest@15927

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@15927

jest-circus

npm i https://pkg.pr.new/jest-circus@15927

jest-cli

npm i https://pkg.pr.new/jest-cli@15927

jest-config

npm i https://pkg.pr.new/jest-config@15927

@jest/console

npm i https://pkg.pr.new/@jest/console@15927

@jest/core

npm i https://pkg.pr.new/@jest/core@15927

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@15927

jest-diff

npm i https://pkg.pr.new/jest-diff@15927

jest-docblock

npm i https://pkg.pr.new/jest-docblock@15927

jest-each

npm i https://pkg.pr.new/jest-each@15927

@jest/environment

npm i https://pkg.pr.new/@jest/environment@15927

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@15927

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@15927

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@15927

@jest/expect

npm i https://pkg.pr.new/@jest/expect@15927

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@15927

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@15927

@jest/globals

npm i https://pkg.pr.new/@jest/globals@15927

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@15927

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@15927

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@15927

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@15927

jest-message-util

npm i https://pkg.pr.new/jest-message-util@15927

jest-mock

npm i https://pkg.pr.new/jest-mock@15927

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@15927

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@15927

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@15927

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@15927

jest-resolve

npm i https://pkg.pr.new/jest-resolve@15927

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@15927

jest-runner

npm i https://pkg.pr.new/jest-runner@15927

jest-runtime

npm i https://pkg.pr.new/jest-runtime@15927

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@15927

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@15927

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@15927

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@15927

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@15927

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@15927

@jest/transform

npm i https://pkg.pr.new/@jest/transform@15927

@jest/types

npm i https://pkg.pr.new/@jest/types@15927

jest-util

npm i https://pkg.pr.new/jest-util@15927

jest-validate

npm i https://pkg.pr.new/jest-validate@15927

jest-watcher

npm i https://pkg.pr.new/jest-watcher@15927

jest-worker

npm i https://pkg.pr.new/jest-worker@15927

pretty-format

npm i https://pkg.pr.new/pretty-format@15927

commit: 86a9ff8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant