Moving Caching logic to central file #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DSilence Any idea whether there's a running system out there that still relies on it? I'm thinking of removing it (i.e. this PR) 4.x unless this actually got used |
|
Caching.fs will move into EventstoreDb and be linked into EventStore and SqlStreamStore rather than living in Equinox.Core (see #196) |
|
Not sure there is anything in prod currently relying on async implementation. Could be useful for file-based cache though (or anything network related) |
bartelink
changed the title
bartelink
force-pushed
the
remove-cache-async
branch
from
6be1b5a
to
0902721
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep/cleanup in advance of #196 potentially introducing a third clone of the caching logic into the codebase