Skip to content

Commit eb9fce7

Browse files
committed
Remove redundant stable tag from workflows
- Remove stable tag from all workflows (esp-idf, platformio, esp-matter) - Simplify to 3 tags: latest, sha, version - Update esp-idf.yml, platformio.yml workflows - stable was redundant duplicate of latest with no functional difference Documentation: - Update github-actions-standards.mdc - Remove stable from tag strategy and examples - Add note explaining stable tag removal - Update Push Behavior table to reflect new tags Benefits: - Simpler workflow (one less tag) - Less clutter in GHCR - Clearer tag purpose: latest (floating), version (pinned), sha (debug)
1 parent 798d90c commit eb9fce7

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

.cursor/rules/github-actions-standards.mdc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ jobs:
130130
push: ${{ github.repository_owner == 'jethome-iot' && github.ref_name == 'master' }}
131131
tags: |
132132
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.<IMAGE_NAME> }}:latest
133-
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.<IMAGE_NAME> }}:stable
134133
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.<IMAGE_NAME> }}:sha-${{ steps.tags.outputs.sha_short }}
135134
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.<IMAGE_NAME> }}:<prefix>-${{ matrix.version }}
136135
cache-from: type=gha,scope=${{ env.<IMAGE_NAME> }}
@@ -210,7 +209,7 @@ jobs:
210209

211210
| Branch/Event | Build | Push to GHCR | Tags Generated |
212211
|--------------|-------|--------------|----------------|
213-
| Main repo master push | Yes | Yes | `latest`, `stable`, `VERSION`, `sha-SHA` |
212+
| Main repo master push | Yes | Yes | `latest`, `VERSION`, `sha-SHA` |
214213
| Main repo dev push | Yes | No | None |
215214
| Main repo PR | Yes | No | None |
216215
| Main repo workflow_dispatch | Yes | Only on master | Same as master if on master |
@@ -225,16 +224,17 @@ jobs:
225224
- Secure: Only main repo on master can push to GHCR
226225

227226
**Tag Strategy:**
228-
- `latest` / `stable` - Floating tags for convenience
227+
- `latest` - Floating tag for convenience (always points to newest build)
229228
- `<prefix>-v<version>` - Main version tag (e.g., `idf-v5.4.1`, `pio-v6.1.18`)
230229
- `sha-<commit>` - Git commit tracking for debugging/rollback
231230
- **No date tags** - Version tags are semantic and clear; SHA tags provide precise tracking
231+
- **No stable tag** - Removed as redundant duplicate of `latest`
232232
- All tags created simultaneously in single build step via `docker/build-push-action`
233233

234234
**Tag Order (Critical for GHCR Display):**
235235
- List tags in the `tags:` field of `docker/build-push-action`
236236
- **Version tag MUST be last** - GHCR displays the last tag as the primary tag
237-
- Order: `latest`, `stable`, `sha-<commit>`, `<prefix>-v<version>` (last = primary display)
237+
- Order: `latest`, `sha-<commit>`, `<prefix>-v<version>` (last = primary display)
238238
- All tags point to the same multi-arch manifest automatically
239239

240240
## Workflow Testing

.github/workflows/esp-idf.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ jobs:
7070
push: ${{ github.repository_owner == 'jethome-iot' && github.ref_name == 'master' }}
7171
tags: |
7272
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_IDF_IMAGE_NAME }}:latest
73-
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_IDF_IMAGE_NAME }}:stable
7473
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_IDF_IMAGE_NAME }}:sha-${{ steps.tags.outputs.sha_short }}
7574
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_IDF_IMAGE_NAME }}:idf-${{ matrix.idf_base_tag }}
7675
cache-from: type=gha,scope=${{ env.ESP_IDF_IMAGE_NAME }}
@@ -120,7 +119,6 @@ jobs:
120119
push: ${{ github.repository_owner == 'jethome-iot' && github.ref_name == 'master' }}
121120
tags: |
122121
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_MATTER_IMAGE_NAME }}:latest
123-
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_MATTER_IMAGE_NAME }}:stable
124122
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_MATTER_IMAGE_NAME }}:sha-${{ steps.tags.outputs.sha_short }}
125123
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.ESP_MATTER_IMAGE_NAME }}:idf-${{ matrix.jethome_idf_base_tag }}-matter-${{ matrix.esp_matter_version }}
126124
cache-from: type=gha,scope=${{ env.ESP_MATTER_IMAGE_NAME }}

.github/workflows/platformio.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ jobs:
6666
push: ${{ github.repository_owner == 'jethome-iot' && github.ref_name == 'master' }}
6767
tags: |
6868
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.PLATFORMIO_IMAGE_NAME }}:latest
69-
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.PLATFORMIO_IMAGE_NAME }}:stable
7069
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.PLATFORMIO_IMAGE_NAME }}:sha-${{ steps.tags.outputs.sha_short }}
7170
${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.PLATFORMIO_IMAGE_NAME }}:pio-${{ matrix.pio_version }}
7271
cache-from: type=gha,scope=${{ env.PLATFORMIO_IMAGE_NAME }}

0 commit comments

Comments
 (0)