Merged
Conversation
Co-authored-by: adeepn <64684523+adeepn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add cosign signing for Docker images
Add cosign signing for Docker images
Oct 10, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR implements cryptographic signing for Docker images in the platformio.yml workflow using Cosign with keyless signing to enhance supply chain security and provide image provenance verification.
- Added Cosign integration to the GitHub Actions workflow for automatic image signing
- Updated documentation to inform users about signed images and provide verification instructions
- Configured OIDC permissions for keyless signing without managing private keys
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/platformio.yml |
Added Cosign installation, image signing step, and OIDC permissions for keyless signing |
README.md |
Added brief mention of Cosign signing for all published images |
images/platformio/README.md |
Added detailed documentation on image signing and verification instructions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| TAGS: ${{ steps.tags.outputs.TAGS }} | ||
| run: | | ||
| images="" | ||
| for tag in ${TAGS//,/ }; do |
There was a problem hiding this comment.
The shell parameter expansion ${TAGS//,/ } may not handle edge cases like empty tags or tags with spaces correctly. Consider using a more robust approach like echo $TAGS | tr ',' ' ' or proper array handling to ensure reliable tag parsing.
Suggested change
| for tag in ${TAGS//,/ }; do | |
| for tag in $(echo "$TAGS" | tr ',' ' '); do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements cryptographic signing for all Docker images built in the platformio.yml workflow using Cosign with keyless signing.
What Changed
Workflow Updates (
.github/workflows/platformio.yml)id-token: writepermission to enable GitHub OIDC token access for keyless signingsigstore/cosign-installer@v3.5.0actionDocumentation Updates
Updated
README.mdandimages/platformio/README.mdto:How It Works
This implementation uses keyless signing with GitHub OIDC, which means:
Verification
Users can verify image signatures using:
Security Benefits
Notes
Closes issue about adding cosign signing for Docker images built in platformio.yml workflow.
Original prompt
Fixes #1
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.