Merged
Conversation
Collaborator
|
Hey @clessg, this PR looks really helpful! Just wondering -- why does the plugin install CoreServices on darwin systems? Does this fix an issue you were seeing with Elixir and Devbox? |
Contributor
Author
|
Hey John, thanks for the response! So happy to see Devbox is alive and well, I can't live without it now :) Anyway, yup! I should have mentioned the Darwin part. On Mac/Darwin, the Elixir package Adding CoreServices seems to resolve the issue. Maybe there's another way but I haven't found it. Considering Elixir almost always goes in tandem with Phoenix (a la Ruby and Rails) or another live-reloading framework, I figured I'd throw in that fix to minimize unexpected errors on Mac. |
Collaborator
|
Thanks for the explanation! Going to merge and will test further in the next pre-release |
Lagoja
approved these changes
Jan 3, 2025
yasuaki640
added a commit
to yasuaki640/devbox
that referenced
this pull request
Jan 18, 2026
…plugin The CoreServices framework reference was added to fix file_system package compilation on macOS (PR jetify-com#2462), but is no longer needed with the new Darwin SDK pattern introduced in nixpkgs. With the updated Darwin stdenv, the Apple SDK (including CoreServices) is now automatically provided, making the explicit framework reference obsolete. The old pattern using darwin.apple_sdk_11_0 has been removed from nixpkgs, causing installation failures on macOS. This change removes the packages section entirely and bumps the plugin version to 0.0.2. Fixes jetify-com#2705 Fixes jetify-com#2557
savil
pushed a commit
that referenced
this pull request
Jan 19, 2026
## Summary Fixes the elixir plugin to work with the new Darwin SDK pattern in nixpkgs by removing the explicit `darwin.apple_sdk.frameworks.CoreServices` dependency. ## How was it tested? Tested on **macOS (darwin-arm64)**: 1. **Built devbox locally**: `devbox run build` 2. **Added elixir package**: `devbox add elixir` - ✅ No `darwin.apple_sdk_11_0 has been removed` error - ✅ Successfully installed Elixir 1.18.1 with Erlang/OTP 27 <img width="736" height="37" alt="image" src="https://github.com/user-attachments/assets/5808dfab-b525-4816-a19c-69ba8070dfaa" /> 3. **Verified elixir functionality**: `elixir --version` successfully showed version information <img width="1506" height="272" alt="image" src="https://github.com/user-attachments/assets/37230f7f-1b2a-42c4-83da-c8db28b70984" /> 4. **Tested the original issue** - compiling `file_system` package (used by Phoenix for Live Reload): - Created a Mix project with `file_system` dependency - ✅ Successfully compiled the native macOS FSEvents watcher - Log output: `Compiling file system watcher for Mac... Done.` <img width="609" height="203" alt="image" src="https://github.com/user-attachments/assets/b13e60c5-1c38-417a-926c-fa4d358dc5b6" /> This confirms that the CoreServices framework is now automatically available through the new Darwin stdenv, and the explicit `darwin.apple_sdk.frameworks.CoreServices` package reference is no longer needed. ## Background The elixir plugin currently includes `darwin.apple_sdk.frameworks.CoreServices` in its packages section (added in #2462 (comment) to fix `file_system` package compilation on macOS). However, this reference uses the old Darwin SDK pattern that has been removed from nixpkgs. As documented in [NixOS/nixpkgs#354146](NixOS/nixpkgs#354146), nixpkgs has migrated to a new Darwin SDK pattern where: - The stdenv now provides a default SDK automatically - Framework dependencies like CoreServices are bundled in the SDK - Explicit framework references using the old `darwin.apple_sdk_11_0` pattern cause errors ## Changes - Removed the `packages` section from `plugins/elixir.json` - Bumped plugin version from `0.0.1` to `0.0.2` The `file_system` package will continue to work on macOS because CoreServices is now automatically available through the new Darwin stdenv. Fixes #2705 Fixes #2557
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a very basic elixir plugin to simplify installation to a simple
devbox add elixir. Also now properly stores Mix/Hex artifacts in.devbox/virtenv.How was it tested?