feat(rule-engine): 添加字段分组名称支持 #700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PengyuDeng
commented
Oct 16, 2025
PengyuDeng
commented
- 在TermColumn中新增groupName字段
- 更新with方法以支持从PropertyMetadata获取分组名称
- 在TermColumn中新增groupName字段 - 更新with方法以支持从PropertyMetadata获取分组名称
zhou-hao
reviewed
Oct 17, 2025
| public TermColumn with(PropertyMetadata metadata) { | ||
| setColumn(metadata.getId()); | ||
| setName(metadata.getName()); | ||
| setGroupName(metadata.getExpand("groupName").orElse("").toString()); |
Member
There was a problem hiding this comment.
- 魔法值,使用常量定义groupName,推荐在
PropertyMetadataConstants中定义
interface Group{
String name = "groupName";
}- 那为啥不直接放到others里呢?
- 使用 ConfigKey 动态处理分组名称配置
zhou-hao
reviewed
Oct 23, 2025
| setFullNameCode(I18nSpec.of(null, localeName)); | ||
| setFullName(fullNameCode.resolveI18nMessage()); | ||
| } | ||
| ConfigKey<String> groupName = ConfigKey.of("groupName", "分组名称", String.class); |
Member
There was a problem hiding this comment.
在PropertyMetadataConstants 中定义
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.