-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(timescaledb): 支持配置TimescaleDB函数所在的schema #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,16 +23,11 @@ | |
|
|
||
| public class TimescaleDBCreateTableSqlBuilder extends CommonCreateTableSqlBuilder { | ||
|
|
||
| private String schema; | ||
|
|
||
| public TimescaleDBCreateTableSqlBuilder(String schema) { | ||
| this.schema = schema; | ||
| } | ||
|
|
||
| @Override | ||
| public SqlRequest build(RDBTableMetadata table) { | ||
| DefaultBatchSqlRequest sqlRequest = (DefaultBatchSqlRequest) super.build(table); | ||
|
|
||
|
|
||
| table.getFeature(CreateHypertable.ID) | ||
| .ifPresent(createHypertable -> sqlRequest.addBatch(createCreateHypertableSQL(table, createHypertable))); | ||
|
|
||
|
|
@@ -47,9 +42,14 @@ private SqlRequest createCreateRetentionPolicySQL(RDBTableMetadata table, Create | |
|
|
||
| String interval = createHypertable.getInterval().getNumber().intValue() + " " | ||
| + createHypertable.getInterval().getUnit().name().toLowerCase(); | ||
| String functionSchema = table.getSchema() | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 直接 table.findFeature就行了? |
||
| .getDatabase() | ||
| .getFeatureNow(TimescaleDBPropertiesFeature.ID) | ||
| .getProperties() | ||
| .getFunctionSchema(); | ||
|
|
||
| return SqlRequests.of( | ||
| "SELECT "+ schema +".add_retention_policy( ? , INTERVAL '" + interval + "')", | ||
| "SELECT " + "\"" + functionSchema + "\"" + ".add_retention_policy( ? , INTERVAL '" + interval + "')", | ||
| table.getFullName() | ||
| ); | ||
| } | ||
|
|
@@ -58,9 +58,13 @@ private SqlRequest createCreateHypertableSQL(RDBTableMetadata table, CreateHyper | |
|
|
||
| String interval = createHypertable.getChunkTimeInterval().getNumber().intValue() + " " | ||
| + createHypertable.getChunkTimeInterval().getUnit().name().toLowerCase(); | ||
|
|
||
| String functionSchema = table.getSchema() | ||
| .getDatabase() | ||
| .getFeatureNow(TimescaleDBPropertiesFeature.ID) | ||
| .getProperties() | ||
| .getFunctionSchema(); | ||
| return SqlRequests.of( | ||
| "SELECT "+ schema +".create_hypertable( ? , ? , chunk_time_interval => INTERVAL '" + interval + "')", | ||
| "SELECT " + "\"" + functionSchema + "\"" + ".create_hypertable( ? , ? , chunk_time_interval => INTERVAL '" + interval + "')", | ||
| table.getFullName(), | ||
| table.getColumnNow(createHypertable.getColumn()).getName() | ||
| ); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
...c/main/java/org/jetlinks/community/timescaledb/metadata/TimescaleDBPropertiesFeature.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| package org.jetlinks.community.timescaledb.metadata; | ||
|
|
||
| import lombok.AllArgsConstructor; | ||
| import lombok.Getter; | ||
| import org.hswebframework.ezorm.core.FeatureId; | ||
| import org.hswebframework.ezorm.core.FeatureType; | ||
| import org.hswebframework.ezorm.core.meta.Feature; | ||
| import org.jetlinks.community.timescaledb.TimescaleDBProperties; | ||
|
|
||
| @AllArgsConstructor(staticName = "of") | ||
| @Getter | ||
| public class TimescaleDBPropertiesFeature implements Feature, FeatureType { | ||
|
|
||
| public static final FeatureId<TimescaleDBPropertiesFeature> ID = FeatureId.of("TimescaleDBPropertiesFeature"); | ||
|
|
||
| private final TimescaleDBProperties properties; | ||
|
|
||
| @Override | ||
| public String getId() { | ||
| return ID.getId(); | ||
| } | ||
|
|
||
| @Override | ||
| public String getName() { | ||
| return "TimescaleDBPropertiesFeature"; | ||
| } | ||
|
|
||
| @Override | ||
| public FeatureType getType() { | ||
| return this; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样并不准确. 重写get方法更合适?