Skip to content

Add integration tests for manage permissions #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paustint
Copy link
Contributor

No description provided.

@paustint paustint requested a review from Copilot March 20, 2025 01:44
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds integration tests and supporting changes for managing permissions. The key changes include the addition of new integration tests for permission management flows, the implementation of a ManagePermissionPage page object model, and updates to related fixtures, UI components, and test utility exports.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
apps/jetstream-e2e/src/tests/manager-permissions/manager-permissions.spec.ts Introduces integration tests for managing permissions operations and validation of field dependencies.
libs/test/e2e-utils/src/lib/pageObjectModels/ManagePermissionPage.model.ts Implements page object methods for navigating to permissions manager, selecting entities, and handling editor navigation.
libs/features/manage-permissions/src/utils/permission-manager-table-utils.tsx Adds testId attributes to aid in test targeting for row actions.
libs/test/e2e-utils/src/index.ts Exports the new ManagePermissionPage model.
apps/jetstream-e2e/src/fixtures/fixtures.ts Updates fixtures to include the ManagePermissionPage for use in tests.
libs/ui/src/lib/list/ListWithFilterMultiSelect.tsx Introduces an optional testId prop to support testing.
libs/features/manage-permissions/src/ManagePermissionsSelection.tsx Passes testId props to list components for consistent targeting in tests.
libs/ui/src/lib/sobject-list/ConnectedSobjectListMultiSelect.tsx Replaces Fragment with a div and adds a testId to enable test targeting of the sobject list.
Comments suppressed due to low confidence (2)

libs/test/e2e-utils/src/lib/pageObjectModels/ManagePermissionPage.model.ts:31

  • There is an inconsistency between the continueButton (selected as a 'link') and continueButtonDisabled (selected as a 'button') which could indicate a mismatch in the rendered element types. Confirm that both selectors correctly target the expected elements for their respective states.
this.continueButton = page.getByRole('link', { name: 'Continue' });

apps/jetstream-e2e/src/fixtures/fixtures.ts:69

  • Removing the playwrightPage argument from the QueryPage instantiation might impact tests if QueryPage relies on it. Verify that all required dependencies for QueryPage have been appropriately updated.
await use(new QueryPage(page, apiRequestUtils));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant