fix: format indent is not honored for all tokens #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the indent is applied correctly to all tokens Resolves: #272
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the numIndent option was not being properly applied to all tokens during SOQL query formatting. Previously, the formatter hardcoded a single tab character (\t) when adding new lines after keywords, ignoring the configured indent value.
Key Changes:
- Updated the
formatClausemethod to usegetIndent()instead of hardcoded\t - Added test case to verify correct indentation with
numIndent: 2
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/formatter/formatter.ts | Changed formatClause to use getIndent() method instead of hardcoded tab character |
| test/test-cases-for-format.ts | Added test case 18 to verify numIndent option works correctly, and reformatted existing test cases for consistency |
| CHANGELOG.md | Added version 6.3.1 entry documenting the indent fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the indent is applied correctly to all tokens
Resolves: #272