Skip to content

Conversation

@shaoxt
Copy link
Contributor

@shaoxt shaoxt commented Oct 29, 2024

Fixes #12436

Allow headers size extend to maxRequestHeadersSize in http client

@sbordet sbordet requested review from gregw and sbordet and removed request for gregw November 5, 2024 17:13
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please:

  1. Apply the review comments.
  2. Rebase these changes against branch jetty-12.1.x, and squash them in just 1 commit.
  3. Move the tests to HttpClientTest and actually call setMaxRequestHeadersSize() in the test so that we will test it is working.

I am probably make your changes part of a larger set of changes that improve the behavior of the current implementation.

Thanks!

@shaoxt
Copy link
Contributor Author

shaoxt commented Nov 7, 2024

Thanks for reviewing the PR. Created a new PR for required changes
#12499
For some reasons, the last commits I tried to squash them in 1 commit. but git said the commits from two different parents.

Can you please:

  1. Apply the review comments.
  2. Rebase these changes against branch jetty-12.1.x, and squash them in just 1 commit.
  3. Move the tests to HttpClientTest and actually call setMaxRequestHeadersSize() in the test so that we will test it is working.

I am probably make your changes part of a larger set of changes that improve the behavior of the current implementation.

Thanks!

@shaoxt shaoxt closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow headers size extend to maxRequestHeadersSize in http client

2 participants