Fix #12481 Handle headers with 304 responses #12484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Content-Length header to be set with a 304 response Follow RFC9110 recommendations for headers to be sent with 304 response.
Allow Content-Length header to be set with a 304 response Follow RFC9110 recommendations for headers to be sent with 304 response.
Contributor
Author
|
@joakime technically, we should be setting the etag with 304 responses, but it is too difficult for the GzipResponse wrapper to know if the response would have been compressed or not, and thus it cannot tell if the etag should have the suffix appended. All in all, looking for a better solution. |
lorban
requested changes
Nov 6, 2024
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/ResourceService.java
Show resolved
Hide resolved
jetty-core/jetty-server/src/test/java/org/eclipse/jetty/server/handler/ResourceHandlerTest.java
Show resolved
Hide resolved
sbordet
requested changes
Nov 6, 2024
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/ResourceService.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/ResourceService.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/ResourceService.java
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/ResourceService.java
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/ResourceService.java
Show resolved
Hide resolved
lorban
requested changes
Nov 7, 2024
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/ResourceService.java
Show resolved
Hide resolved
sbordet
approved these changes
Nov 8, 2024
lorban
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12481 Allow Content-Length header to be set with a 304 response Follow RFC9110 recommendations for headers to be sent with 304 response.