Fixes #12488 - HTTP/2 headers may not be split in CONTINUATION frames. #12489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sbordet
commented
Nov 6, 2024
sbordet
commented
- Removed unnecessary and wrong initialization of Parser and Generator properties, as they are initialized by SETTINGS frames (or they have default values already).
- Fixed headers generation, taking into account maxHeaderListSize and maxFrameSize correctly.
* Removed unnecessary and wrong initialization of Parser and Generator properties, as they are initialized by SETTINGS frames (or they have default values already). * Fixed headers generation, taking into account maxHeaderListSize and maxFrameSize correctly. Signed-off-by: Simone Bordet <[email protected]>
lorban
requested changes
Nov 6, 2024
Contributor
lorban
left a comment
lorban
left a comment
There was a problem hiding this comment.
There's a broken proxy test that seems directly related to this change.
…split'. Signed-off-by: Simone Bordet <[email protected]>
* Introduced HTTP2Client.maxRequestHeadersSize. * Initialized HpackEncoder.maxHeaderListSize. Signed-off-by: Simone Bordet <[email protected]>
lorban
previously approved these changes
Nov 11, 2024
| _debug = LOG.isDebugEnabled(); | ||
| setMaxTableCapacity(HpackContext.DEFAULT_MAX_TABLE_CAPACITY); | ||
| setTableCapacity(HpackContext.DEFAULT_MAX_TABLE_CAPACITY); | ||
| setMaxHeaderListSize(4096); |
Contributor
There was a problem hiding this comment.
Shouldn't that be a constant?
Introduced HpackContext.DEFAULT_MAX_HEADER_LIST_SIZE. Signed-off-by: Simone Bordet <[email protected]>
lorban
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.