Align embedded and XML defaults for HttpConfiguration #12555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #11947 by aligning embedded and XML HttpConfiguration defaults
…gnEmbeddedAndXmlDefaults
Fix #11947 by aligning embedded and XML HttpConfiguration defaults Revert most changes
lachlan-roberts
previously requested changes
Nov 22, 2024
Contributor
lachlan-roberts
left a comment
lachlan-roberts
left a comment
There was a problem hiding this comment.
I think the test failures are not a flake, the SiweTest was expecting the full URI in the redirect but now only gets the relative redirect.
Fix #11947 by aligning embedded and XML HttpConfiguration defaults Fixed SIWE
Contributor
Author
Fixed. Also those tests had bad ee10 packages. Have you blogged about this feature yet? |
janbartel
approved these changes
Nov 27, 2024
sbordet
requested changes
Nov 27, 2024
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/Server.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/Server.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/DefaultHandler.java
Show resolved
Hide resolved
olamy
approved these changes
Nov 29, 2024
sbordet
approved these changes
Nov 29, 2024
lorban
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11947 by aligning embedded and XML HttpConfiguration defaults