Enhance HTTP Compliance CRLF modes #12564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added modes to allow strict requirement for CRLF termination of headers and/or chunks
gregw
requested review from
joakime and
lorban
and removed request for
lorban
Added modes to allow strict requirement for CRLF termination of headers and/or chunks
sbordet
requested changes
Nov 25, 2024
Contributor
sbordet
left a comment
sbordet
left a comment
There was a problem hiding this comment.
- What happens now if we have a request with mixed EOL, e.g. some are just \n, and some \r\n, still good and we have tests?
- Please update the documentation about the compliance, defaulting to 9110 where now is 7230 in
programming-guide/server/compliance. - This must be backported to 12.0.x, so I would rather rebase this PR on 12.0.x and then merge forward.
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpCompliance.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpCompliance.java
Outdated
Show resolved
Hide resolved
Added modes to allow strict requirement for CRLF termination of headers and/or chunks Updates from review
Contributor
Author
If configured to accept LF EOL, then we accept a mix of LF and CRLF. I guess we could have a semi strict mode that once you see a LF then any CRLF is an error... but that's not what the RFC says. If you want to be strict, then just accept CRLF only.
Done.
I'm not sure we need to backport. There is no actual issue with jetty here and this is just tightening the compliance as a future proofing exercise. Let's talk offline. |
sbordet
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added modes to allow strict requirement for CRLF termination of headers and/or chunks