Introduced ClientConnector.ConnectListener for TCP connect events. #12570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced ClientConnector.ConnectListener with events for TCP connection establishment/failure. Signed-off-by: Oleksandr Krutko <[email protected]>
lorban
requested changes
Nov 26, 2024
Contributor
lorban
left a comment
lorban
left a comment
There was a problem hiding this comment.
The implementation looks good, but I think naming/documentation could be improved as this introduces yet another event listener that may be confused with existing ones.
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/ClientConnector.java
Show resolved
Hide resolved
lorban
previously approved these changes
Nov 26, 2024
Cleaned up contribution by @arsenalzp. Added more test cases for blocking and non-blocking. Added documentation. Signed-off-by: Simone Bordet <[email protected]>
sbordet
force-pushed
the
fix/jetty-12.0.x/9529/@arsenalzp-tcp-connect-listener
branch
from
3728fbd to
5273fcf
Compare
sbordet
deleted the
fix/jetty-12.0.x/9529/@arsenalzp-tcp-connect-listener
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9529.