Fix #12578 pretty print getParameterMap #12585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #12578 pretty print getParameterMap Added test for parameters
joakime
previously approved these changes
Nov 26, 2024
Fix #12578 pretty print getParameterMap checkstyle
joakime
previously requested changes
Nov 27, 2024
Contributor
joakime
left a comment
joakime
left a comment
There was a problem hiding this comment.
Can we have a TypeUtil.toString(Map<String,String> map) that does this? and have it used in both places?
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/Fields.java
Outdated
Show resolved
Hide resolved
Fix #12578 pretty print getParameterMap Added TypeUtil method
olamy
approved these changes
Nov 29, 2024
lorban
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12578 pretty print getParameterMap
Added test for parameters