Fixes #5308 - Extract httpConfig and scheduler configuration out of jetty.xml. #12594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregw
requested changes
Nov 28, 2024
Contributor
gregw
left a comment
gregw
left a comment
There was a problem hiding this comment.
All good, except I think we need to clarify/normalize the sslHttpConfig instance, as it is currently a bit hidden
documentation/jetty/modules/operations-guide/pages/modules/standard.adoc
Show resolved
Hide resolved
gregw
approved these changes
Nov 28, 2024
…etty.xml. Move the scheduler and http configuration into separate modules. Updated and expanded the documentation. Signed-off-by: Simone Bordet <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
sbordet
force-pushed
the
fix/jetty-12.1.x/5308/split-jetty-xml
branch
from
46dbbcb to
39bb0ef
Compare
Signed-off-by: Simone Bordet <[email protected]>
Small optimization on HttpParser
…1.x/5308/split-jetty-xml # Conflicts: # jetty-core/jetty-server/src/main/config/etc/jetty.xml
Contributor
|
@sbordet I fixed the tests and the merge conflict |
Contributor
|
@sbordet I obviously have more tests to fix... On it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the scheduler and http configuration into separate modules.
Updated and expanded the documentation.