Skip to content

Fixes #14870 - Refactor compliance checks.#14871

Open
sbordet wants to merge 5 commits intojetty-12.1.xfrom
fix/jetty-12.1.x/14870-common-compliance-checks
Open

Fixes #14870 - Refactor compliance checks.#14871
sbordet wants to merge 5 commits intojetty-12.1.xfrom
fix/jetty-12.1.x/14870-common-compliance-checks

Conversation

@sbordet
Copy link
Copy Markdown
Contributor

@sbordet sbordet commented Apr 17, 2026

Refactored compliance checks that are common across all HTTP versions to common code.

Refactored compliance checks that are common across all HTTP versions to common code.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet requested review from joakime and lorban April 17, 2026 13:45
@sbordet sbordet moved this to 👀 In review in Jetty 12.1.9 Apr 17, 2026
@sbordet sbordet self-assigned this Apr 17, 2026
@sbordet sbordet linked an issue Apr 17, 2026 that may be closed by this pull request
joakime
joakime previously approved these changes Apr 17, 2026
Copy link
Copy Markdown
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joakime
Copy link
Copy Markdown
Contributor

joakime commented Apr 17, 2026

There's a few scenarios that need to be solved.
Forwarding, HTTP/1.0, CONNECT, etc ...

Copy link
Copy Markdown
Contributor

@lorban lorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright, but break a lot of tests

… field value may be empty if also the absolute URI authority is empty.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added 3 commits April 19, 2026 11:48
…authority-form in CONNECT requests.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
… case of CONNECT requests.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

Refactor compliance checks

3 participants