Add simplification for String.join singleton #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lue-bird
reviewed
Oct 16, 2025
Comment on lines
+11989
to
+11990
| case Node.value lastArg of | ||
| Expression.ListExpr [ Node singleRange _ ] -> |
Collaborator
There was a problem hiding this comment.
I'd match on AstHelpers.getListSingleton for the last argument to also cover List.singleton calls. See https://github.com/jfmengels/elm-review-simplify/blob/main/src/Simplify/AstHelpers.elm#L201-L221
lue-bird
requested changes
Oct 16, 2025
Comment on lines
+11997
to
+12005
| [ Fix.removeRange | ||
| { start = checkInfo.parentRange.start | ||
| , end = singleRange.start | ||
| } | ||
| , Fix.removeRange | ||
| { start = singleRange.end | ||
| , end = checkInfo.parentRange.end | ||
| } | ||
| ] |
Collaborator
There was a problem hiding this comment.
This will e.g. fix
[ f <| string ] |> String.join sep
--> f <| stringwhich can lead to invalid syntax.
A better alternative is replaceBySubExpressionFix, see https://github.com/jfmengels/elm-review-simplify/blob/main/src/Simplify.elm#L14642-L14648
Adding a test for this would be nice, too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #336