Basics.abs simplifications

[lue-bird]

abs 3
--> 3

abs (abs n)
--> abs n

abs -n
--> abs n

max n -n
--> abs n

min n -n
--> -(abs n)

including composition where possible.

[jfmengels]

Instead of calling AstHelpers.getUncomputedNumberValue, couldn't we try to find the negation node, and only remove the - sign(s)? That way we could preserve the style in all cases.

[lue-bird]

I think, since that check is after the "abs on negated" checks, any input argument should never be negated in practice (basically the else should be dead code).

[jfmengels]

Thanks 😊