Update CleanDockerImages inline with code comments - #373
Open
Shop-kins wants to merge 1 commit into
Open
Conversation
Code comments in this file imply that the images are deleted immediately, currently this is not the case. This change rectifies this.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
|
Contributor
|
@Shop-kins Thanks for your contribution. Are still looking for this change, if yes. Can you rebase we will review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code comments in this file imply that the images are deleted immediately, currently this is not the case. This change rectifies this.
The comment in question is on line 67, alternatively this comment can be altered to not say immediately 👍