Skip to content

Conversation

@eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Jan 7, 2026

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

This PR changes the NPM package handler to test-based fixes instead of cli command fixes.
As past of the change we ease the installation after a fix is performed to only regenerate the lock file, hence reducing the strict build process we used to have and make the process less error prone

Missing testcase:
We need to add a new integration test test case to TestScanRepositoryCmd_Run that verifies we do not regenerate a lock file if it doesnt exists in remote. since the TestScanRepositoryCmd_Run is not passing right now and we need to fix it I added it to the overall test plan for future addition

@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Jan 7, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 7, 2026
@eyalk007
Copy link
Collaborator

eyalk007 commented Jan 7, 2026

please provide a link to a fix pr

Copy link
Collaborator

@eyalk007 eyalk007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed most of files
please tell me you are done so i can rereveiw

@eranturgeman
Copy link
Contributor Author

eranturgeman commented Jan 19, 2026

please provide a link to a fix pr

https://github.com/eranturgeman/npm-small/pull/14

Screenshot 2026-01-19 at 13 13 27

@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 19, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 19, 2026
@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants