Fix the golang package updater #997
Conversation
eyalk007
commented
Dec 15, 2025
eyalk007
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
- Update documentation about new features / new supported technologies
packagehandlers/gopackagehandler.go
Outdated
|
|
||
| func (golang *GoPackageHandler) UpdateDependency(vulnDetails *utils.VulnerabilityDetails) error { | ||
| // Configure resolution from an Artifactory server if needed | ||
| if golang.depsRepo != "" { |
There was a problem hiding this comment.
we want to stop support depsRepo, so those lines can be removed
There was a problem hiding this comment.
i say comment this needs to be back by q1 in my eyes
packagehandlers/gopackagehandler.go
Outdated
| ) | ||
|
|
||
| type GoPackageHandler struct { | ||
| CommonPackageHandler |
There was a problem hiding this comment.
so we dont need and want the CommonPackageHandler right?
There was a problem hiding this comment.
i believe it should not exist
maybe in the future in a diff way with the parsing, but for now we should delete implementation package by package manager
| } | ||
|
|
||
| func (golang *GoPackageHandler) allowLockfileManipulation() []string { | ||
| return append(os.Environ(), "GOFLAGS=-mod=mod") |
There was a problem hiding this comment.
can we have "GOFLAGS=-mod=mod" in a const in the beginning so it will be more clear which flags are being used for each package handler?
There was a problem hiding this comment.
feels like overkill
packagehandlers/gopackagehandler.go
Outdated
| "github.com/jfrog/jfrog-client-go/utils/log" | ||
| ) | ||
|
|
||
| type GoPackageHandler struct { |
There was a problem hiding this comment.
what do you think ti change the PackageHandler name to something more clear? for example "GolangFixPrCreator
There was a problem hiding this comment.
GolangPackageFixer
eyalk007
force-pushed
the
fix-go-package-handler
branch
from
79d4322 to
5cd924b
Compare
eyalk007
changed the title
eyalk007
force-pushed
the
fix-go-package-handler
branch
from
7baec21 to
1df000e
Compare
- Delete old gopackagehandler.go - Add new gopackageupdater.go with improved Go module handling - Add v prefix support for Go modules - Add vendor directory support - Update commonpackagehandler.go with shared utilities
eyalk007
force-pushed
the
fix-go-package-handler
branch
from
b5eabf9 to
31ed7b2
Compare
2 participants
