Skip to content

Add an option to provide descriptor name in Conan graph info command #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Apr 17, 2025

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

This PR adds the ability to specify a custom conanfile (Conan descriptor) name to be used with the 'graph info' command. This enhancement addresses use cases where the descriptor does not have the default name "conanfile.txt".

Since Conan does not require installation before calculating dependencies, we cannot rely on an install command to provide this information. Hence, we leverage the existing functionality of Python package managers to specify a custom descriptor name through options like --requirements-file (or JF_REQUIREMENTS_FILE / pipRequirementsFile in the context of a Frogbot scan) to achieve this same flexibility in Conan.

@eranturgeman eranturgeman added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Apr 17, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 17, 2025
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 17, 2025
@eranturgeman eranturgeman requested a review from attiasas April 17, 2025 12:03
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 17, 2025
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 17, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 17, 2025
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 17, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 17, 2025
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure if combining this new logic with the existing PIP flag is ok with our PM

@attiasas attiasas self-requested a review April 20, 2025 07:21
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 23, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 23, 2025
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/commands/audit 0.00% (ø)
github.com/jfrog/jfrog-cli-security/commands/audit/sca/conan 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/commands/audit/sca/conan/conan.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/audit/scarunner.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/jfrog/jfrog-cli-security/commands/audit/sca/conan/conan_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants