Added retry mechanism for close contentReader in download. #1099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhanurp
reviewed
Mar 20, 2025
agrasth
force-pushed
the
addRetryMechanisms
branch
from
9cbcd6c to
93fc9b6
Compare
agrasth
force-pushed
the
addRetryMechanisms
branch
from
8928ced to
57749e6
Compare
bhanurp
approved these changes
Mar 28, 2025
fluxxBot
approved these changes
Mar 28, 2025
utils/io/content/contentreader.go
Outdated
| func (cr *ContentReader) Close() error { | ||
| simulateError := false // Set to true in testing, and false in production |
There was a problem hiding this comment.
why do we need this simulate error?
we can simply go ahead and retry
utils/io/content/contentreader.go
Outdated
| @@ -93,13 +98,43 @@ func (cr *ContentReader) Reset() { | |||
| cr.once = new(sync.Once) | |||
| } | |||
|
|
|||
| // Cleanup the reader data. | |||
| // Retry function with forced error simulation | |||
There was a problem hiding this comment.
IMO, we should create a general utility function for retry and pass a function along with comparables for the retry operation
utils/io/content/contentreader.go
Outdated
| // Simulate an error condition for the first few attempts if `simulateError` is true and attempts are less than maxForcedAttempts | ||
| if simulateError && downloadAttempts < maxForcedAttempts { | ||
| lastErr = fmt.Errorf("forced error simulation at attempt %d", downloadAttempts+1) | ||
| downloadAttempts++ |
There was a problem hiding this comment.
why are we referring download here, aren't you just trying to close a opened file?
utils/io/content/contentreader.go
Outdated
| log.Info("Operation succeeded at attempt %d", i+1) | ||
| return nil | ||
| } | ||
| log.Warn("Retry attempt %d failed: %v", i+1, lastErr) |
There was a problem hiding this comment.
log.Warn("Retry attempt %d failed: %v", i+1, lastErr)
log.Warn("Retry attempt %d failed: %v", i+1, lastErr.Error())
utils/io/content/contentreader.go
Outdated
| return nil | ||
| } | ||
| log.Warn("Retry attempt %d failed: %v", i+1, lastErr) | ||
| time.Sleep(time.Millisecond * 100) // Adding a small delay between retries |
agrasth
force-pushed
the
addRetryMechanisms
branch
from
1077be2 to
d1c17bf
Compare
agrasth
force-pushed
the
addRetryMechanisms
branch
from
ce2f37b to
17f0c68
Compare
4 tasks
bhanurp
added
the
safe to test
github-actions
bot
removed
the
safe to test
EyalDelarea
pushed a commit
to EyalDelarea/jfrog-client-go
that referenced
this pull request
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance Retry Mechanism for Content Reader Closure in Downloads
Summary:
This PR improves the reliability of the download process by introducing a retry mechanism when closing the contentReader.
Changes:
Added a retry mechanism to handle potential failures when closing the contentReader in the download process.