fix(permission): stabilize Read order to eliminate spurious no-op diffs - #320
Open
Mahanmmi wants to merge 2 commits into
Open
fix(permission): stabilize Read order to eliminate spurious no-op diffs#320Mahanmmi wants to merge 2 commits into
Mahanmmi wants to merge 2 commits into
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
6 tasks
Collaborator
|
Hi @Mahanmmi , Thank you for your contribution. Our CI pipeline issues have been resolved, and we are now accepting contributions again. If you are still interested in submitting this change, please rebase your branch on master and update the CHANGELOG. We look forward to reviewing your pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A permission with multiple
targets(oractions.users/actions.groups) shows a no-op diff on everyterraform plan— items swap positions even though nothing actually changed:The cause is in
fromResourceAPIModelandfromUsersGroupsAPIModel: the API response is unmarshaled into a Gomap, then turned into a slice withlo.MapToSlicebefore being wrapped in atypes.Set. Go map iteration is randomized, so the intermediate slice comes out in a different order on every Read, and that order leaks into state.Fix: sort the slice by
namebefore callingtypes.SetValue. Added a smallsortAttrValuesByNamehelper and call it in both spots.