firdes: Make fractional delay consistent #198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Flipped Nyquist filters do not use fractional sample delay, removed it from API and usage to avoid confusion. Also updated error checking on root and raised cosine filters to check for the correct range [-0.5, 0.5] Fixes # 196
|
You need to remove the space in |
|
I’m not sure if liquid is following semantic versioning, but if so, this would be a major version bump |
Contributor
Author
not intentional but I don't expect this getting merged anytime soon. Anyway thanks for the tip, just noticed I need a rebase as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Flipped Nyquist filters do not use fractional sample
delay, removed it from API and usage to avoid confusion. Also
updated error checking on root and raised cosine filters to
check for the correct range [-0.5, 0.5]
Fixes # 196