Skip to content

Conversation

@asazernik
Copy link

No description provided.

@jgaeddert
Copy link
Owner

Your first commit will cause major issues; removing the call to execute will violate the timing synchronization of the receiver. The way the synchronizer works is that it looks for a known preamble using qdetector, then corrects the timing/carrier/gain offsets from these samples and invokes the callback on the resulting symbols. Because synchronization can happen at any time offset, it's impossible to know what the state of this input buffer is in. The qdetector returns a pointer to the aligned samlples that qdsync needs. Technically yes, it is a recursive call, but only one level deep.

The second commit is perfectly fine. I can try to merge this in, but will have to suppress the first commit.

@asazernik
Copy link
Author

I'll update the pull request to remove that commit.

@asazernik
Copy link
Author

Now it just contains "Add qdsync_cccf_create_cpfsk (#417)"

@asazernik asazernik changed the title QDSync changes (feature and bugfix) Add qdsync_cccf_create_cpfsk (#417) Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants