Fix Qt 6 include conflict - #527
Open
Paulchen-Panther wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@jgarff |
Contributor
Author
|
@jgarff |
|
Hi @jgarff Many thanks in advance!!! |
Closed
1 task
|
Hi @jgarff are there any news regarding the timeline for this mr to move to the master? Community is really waiting for this. |
Lord-Grey
added a commit
to hyperion-project/rpi_ws281x
that referenced
this pull request
Jan 7, 2025
|
@jgarff any news please ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding the library in Cmake (target_include_directories) as submodules, there are conflicts with the compiler detection and your version file under Qt 6. Under Qt 5 the problem does not exist.
Therefore here is a PR that renames your version file to ".version". There are no changes in the core of your library by this PR.
Thank you very much.
Paulchen