fix: correct incorrectly extract salt from tail merging optimization ic204_fw_2049023401#67
Merged
Merged
Conversation
…ic204_fw_2049023401 The last byte of some of the levels was the same, which then caused the compiler to do tail merging optimization, ie a single store with a jump to that store instead of having each access level be self contained. This in turn made naive script based extraction fail.
Contributor
Author
|
Checked other sw versions lightly - there were others with this tail merging optimization, but in inconsequential levels - ie not {1,3,5,7}. It just so happened that this was the only consequential case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last byte of some of the levels was the same, which then caused the compiler to do tail merging optimization, ie a single mov + a jump to that mov instead of having each access level have a self-contained block of movs (ie, a mov for each level cases).
This in turn made my naive script-based extraction fail.
This specific sw version salts have been verified "bad" in hardware, so we for sure aren't making anything worse. There is probably one other sw version that has this defect which I'll get to when I have the time, but I figured I would submit this PR for a known bad issue while I have someone available to test a specific SW version for me.