Skip to content

#8986 filter elements that only contain visuals like images from normal meta - #9170

Open
StephanMeijer wants to merge 2 commits into
jgm:mainfrom
StephanMeijer:feature/split-visuals-from-title
Open

#8986 filter elements that only contain visuals like images from normal meta#9170
StephanMeijer wants to merge 2 commits into
jgm:mainfrom
StephanMeijer:feature/split-visuals-from-title

Conversation

@StephanMeijer

@StephanMeijer StephanMeijer commented Nov 5, 2023

Copy link
Copy Markdown
Contributor

Prevents images as Title to be interpreted as Title.

Visualisation

Untitled drawio (1)

Test Document

Screenshot 2023-11-05 at 18 02 19

@StephanMeijer

Copy link
Copy Markdown
Contributor Author

Related to #8986

@jgm

jgm commented Nov 6, 2023

Copy link
Copy Markdown
Owner

This approach (skipping images) feels a bit ad hoc to me.

I'm thinking it might be preferable to allow items with class Title, Author, or Date to be counted as metadata no matter whether they occur in the document. In the case of Title or Date, only the first would be counted as part of metadata if there are multiple. In the case of multiple Author, they could all be included in a list.

@StephanMeijer

StephanMeijer commented Nov 6, 2023

Copy link
Copy Markdown
Contributor Author

@jgm I do agree that would work in the ideal world. We have users who markup their images as being Title when they are not a title but just incorrectly styled, but are the first Title element in a document.

Is there any valid case for a situation where an image to be correctly marked as being a Title?

@jgm

jgm commented Nov 7, 2023

Copy link
Copy Markdown
Owner

I see now that my comment above wasn't really relevant; I think I was confused because you referenced #8986. That was about skipping an image not marked with Title style and parsing metadata in following paragraphs. This is really a different issue entirely.

Is there any valid case for a situation where an image to be correctly marked as being a Title?

Yes, although it's not common, I think that there are cases where an inline image might be part of a title. I wouldn't want to make this impossible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants