Replaced Bash specific Syntax with POSIX compliant equivalent#9
Open
percychecksum wants to merge 3 commits into
Open
Replaced Bash specific Syntax with POSIX compliant equivalent#9percychecksum wants to merge 3 commits into
percychecksum wants to merge 3 commits into
Conversation
Author
|
Ah, I didn't know it would update the pull request with new commits. I wasn't sure if the notify-send behavior was intentional but I thought it made more sense to send a notification as well when using zenity. Sorry for cluttering the pull request with multiple commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small change to make the script compatible with different POSIX compliant shells (e.g. DASH), that do not support bash syntax. The script would engage in unexpected behavior when run with dash, which is bad because of the implied compatibility by using
#!/bin/sh. Specifically, zenity would always open with color #FFFFFF. Maybe this is the cause of #7 ?