Skip to content

[LR2021] a fix for reverse order of bytes in OOK sync word#1722

Merged
jgromes merged 2 commits intojgromes:masterfrom
lyusupov:lr2021_ook_syncword_order_fix
Mar 14, 2026
Merged

[LR2021] a fix for reverse order of bytes in OOK sync word#1722
jgromes merged 2 commits intojgromes:masterfrom
lyusupov:lr2021_ook_syncword_order_fix

Conversation

@lyusupov
Copy link
Contributor

This is a successor of previously applied PR #1686 that was relevant to GFSK code.
The same issue remains in OOK code.
This PR is intended to fix it.

@jgromes
Copy link
Owner

jgromes commented Mar 11, 2026

Thanks for the contribution! Looking at the code, we should probably add a check that syncWordLen <= RADIOLIB_LR2021_OOK_SYNC_WORD_LEN as the LR2021::setSyncWord method will actually allow up to 8 bytes which is not valid for OOK.

@lyusupov
Copy link
Contributor Author

I am not certain of your intention, sorry.
Please, edit this PR on your discretion.

@jgromes jgromes merged commit 687e517 into jgromes:master Mar 14, 2026
32 checks passed
@jgromes
Copy link
Owner

jgromes commented Mar 14, 2026

Added the check and merged - thanks for the contribution!

@lyusupov lyusupov deleted the lr2021_ook_syncword_order_fix branch March 14, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants