fix: restore default is-outlined button visibility - #4049
Open
q121212 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3996
Problem
Button with class
is-outlinedbut without color modifier (likeis-primary) renders invisible — white text on transparent background. Regression from v0.9.4.Root Cause
$button-ldefaults toscheme-main-l(100% = white in light theme). The default filled button does NOT usebutton-l— it usesbutton-background-lfor bg,button-color-lfor text,button-border-lfor border. Butis-outlinedincorrectly usesbutton-lfor BOTH text and border.Fix
Change
$button-ldefault fromscheme-main-ltotext-strong-l(1 character in variable name). Safe because:button-l