Rewrite Makefile to support older versions - #48
Merged
Merged
Conversation
`make` 3.82 is when `ONESHELL` was introduced, but the default version installed in macos (as of Tahoe 26) is 3.81. As a result the ONESHELL directives are ignored, and the `venv/bin/activate` inclusion is ineffective. There are 2 ways to work around that: 1. single shell, using `. venv/bin/activate && cmd1 && cmd2`, with backslashes for line continuation 2. keep shell commands separate, and invoke venv/bin/___ directly Both approaches work (verified locally), but the venv/bin approach looks better, and removes an easy foot-gun
Owner
Author
|
FYI @parrot-tailor - had to make some changes to make it compatible with macOS's default |
Contributor
|
Ah good call, thanks! I forgot, I have a newer Make installed via Homebrew, this makes sense 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make3.82 is whenONESHELLwas introduced, but the default version installed in macos (as of Tahoe 26) is 3.81. As a result the ONESHELL directives are ignored, and thevenv/bin/activateinclusion is ineffective. There are 2 ways to work around that:. venv/bin/activate && cmd1 && cmd2, with backslashes for line continuationBoth approaches work (verified locally), but the venv/bin approach looks better, and removes an easy foot-gun.
This also tweaks other configs to ensure that rogue/scratch
.pyfiles don't get swept up in any of the checks