Support touching holes #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you add a small test to |
|
Yes, I just added a small unittest. |
gre-42
force-pushed
the
support_touching_holes
branch
from
ee7d8e1 to
230f05c
Compare
gre-42
force-pushed
the
support_touching_holes
branch
from
230f05c to
b6436e6
Compare
|
Does the original publication mention the restriction that holes may not touch (I can not find a free version of it)? If the publication does not mention the restriction, it could make sense to add the duplicate removal as an opt-in feature so people can try it and report problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables support for touching holes by preventing adding duplicate points.
The code has not yet been extensively tested, but it works on a small example.