Regressive Mimi approach for bandwidth extension#61
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements changes to support a new bandwidth extension model (“Regressive Mimi”) while refactoring existing modules to inline metric definitions. Key changes include:
- Updating wav2vec2_for_stp.py to replace external metrics with an inline MetricCollection using CharErrorRate.
- Adding a new RegressiveMimiLightningModule in regressive_mimi.py to support the new model.
- Refactoring ecapa2.py and various configuration files to remove or consolidate metrics definitions.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vibravox/lightning_modules/wav2vec2_for_stp.py | Removed the metrics parameter and replaced it with an inline MetricCollection using CharErrorRate. |
| vibravox/lightning_modules/regressive_mimi.py | Introduces the new RegressiveMimiLightningModule with custom training and evaluation steps. |
| vibravox/lightning_modules/ecapa2.py | Updated metrics instantiation with a new MetricCollection; potential missing import. |
| vibravox/lightning_modules/base_se.py | Added helper methods and logging updates for evaluation steps. |
| vibravox/lightning_datamodules/spkv.py | Fixed a formatting error in the dataset name list. |
| run.py | Removed redundant metrics instantiation and adjusted module instantiation. |
| Various configs (run.yaml, metrics/*, callbacks, README) | Removed old metrics configurations, added a new config for regressive_mimi, and updated documentation. |
Comments suppressed due to low confidence (1)
vibravox/lightning_modules/ecapa2.py:43
- MetricCollection is used in this file but there is no explicit import for it. Please add "from torchmetrics import MetricCollection" at the top of this file to avoid potential runtime errors.
self.metrics = MetricCollection(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.