Skip to content

Fix: bump ESLint 10#32244

Open
qmonmert wants to merge 1 commit intojhipster:mainfrom
qmonmert:eslint10
Open

Fix: bump ESLint 10#32244
qmonmert wants to merge 1 commit intojhipster:mainfrom
qmonmert:eslint10

Conversation

@qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Feb 7, 2026

@github-actions github-actions bot added theme: kubernetes theme: i18n theme: dependencies Pull requests that update a dependency file labels Feb 7, 2026
@qmonmert qmonmert marked this pull request as ready for review February 7, 2026 15:15
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #32146, we should avoid overrides since it doesn’t seem to work in some cases.

I think we should wait for the stack update instead of using overrides.

package.json Outdated
},
"overrides": {
"@eslint/core": "$@eslint/core"
"@eslint/core": "$@eslint/core",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop every overrides.

@qmonmert qmonmert force-pushed the eslint10 branch 4 times, most recently from 91b394d to adfdf5f Compare February 17, 2026 21:44
@qmonmert
Copy link
Contributor Author

@mshima only one override, maybe we can merge?

@qmonmert qmonmert requested a review from mshima February 18, 2026 19:22
@qmonmert
Copy link
Contributor Author

@mshima @DanielFran https://www.npmjs.com/package/eslint-plugin-import-x was not updated since 8 months

@mshima
Copy link
Member

mshima commented Feb 20, 2026

'import-x' is the most important plugin since it removes unused imports and eslint v10 work started un-ts/eslint-plugin-import-x@d3f8d67.
An alternative is https://www.npmjs.com/package/eslint-plugin-import which lacks v10 support too.

It's a prod dependency so we should avoid overrides, because npm only honors overrides in root package.

@qmonmert
Copy link
Contributor Author

ok we wait


/* Completeness */
"skipLibCheck": false /* Skip type checking all .d.ts files. */
"skipLibCheck": true /* Skip type checking all .d.ts files. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be required in every project that is not generated with --skip-jhipster-dependencies option

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found a better solution yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme: dependencies Pull requests that update a dependency file theme: i18n theme: kubernetes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants