Skip to content

fix(maven): avoid overriding existing sonar properties#32637

Open
yuliuyi717-ux wants to merge 4 commits intojhipster:mainfrom
yuliuyi717-ux:codex/issue-22487-0311-0028
Open

fix(maven): avoid overriding existing sonar properties#32637
yuliuyi717-ux wants to merge 4 commits intojhipster:mainfrom
yuliuyi717-ux:codex/issue-22487-0311-0028

Conversation

@yuliuyi717-ux
Copy link
Contributor

Summary

This change avoids noisy Maven warnings caused by properties-maven-plugin overriding properties already defined in the POM during initialize.

What changed

  • Added <override>false</override> to the generated properties-maven-plugin configuration in java-simple-application:code-quality.
  • Added a focused test assertion to ensure generated plugin config keeps override=false.
  • Updated the related snapshot.

Why

When reproducing the issue context from #22487 on current main, plugin-validation warnings are no longer reproducible with current plugin versions, but the generated build still emits a large amount of property-clash warnings from properties-maven-plugin.
This patch reduces that warning noise while keeping sonar property loading in place.

Refs #22487

Validation

npx -y node@22 ./node_modules/.bin/esmocha generators/java-simple-application/generators/code-quality/generator.spec.ts --no-insight --forbid-only

@yuliuyi717-ux yuliuyi717-ux force-pushed the codex/issue-22487-0311-0028 branch from 4e7d9a8 to 2320f58 Compare March 11, 2026 17:48
@yuliuyi717-ux
Copy link
Contributor Author

Rebased this branch onto the latest main and pushed a fresh CI run.\n\nCurrent run result:\n- ✅ Most matrix jobs pass\n- ❌ Two integration jobs fail with environment-style startup issues\n\nFailure signatures:\n1) ms-mf-ng-consul-oauth2-neo4j (n24.14.0/j21)\n - BeanCreationException from Liquibase\n - org.neo4j.driver.exceptions.Neo4jException: Driver execution failed\n - reactor.blockhound.BlockingOperationError: Blocking call! jdk.internal.misc.Unsafe#park\n\n2) ms-vue-eureka-jwt-couchbase-hazelcast (n24.14.0/j21)\n - com.couchbase.client.core.error.UnambiguousTimeoutException\n - reason: BUCKET_NOT_AVAILABLE while reading DATABASE_CHANGELOG_LOCK\n - then repeated ApplicationContext failure threshold in gateway cucumber tests\n\nPR diff is limited to the java-simple code-quality generator (adding <override>false</override> for the properties-maven-plugin), so these two failures look unrelated to the changed files.\n\nIf possible, could a maintainer rerun the failed jobs?

@yuliuyi717-ux yuliuyi717-ux force-pushed the codex/issue-22487-0311-0028 branch from 2320f58 to 2a1b91c Compare March 11, 2026 19:02
@yuliuyi717-ux
Copy link
Contributor Author

yuliuyi717-ux commented Mar 11, 2026

Quick update: I retriggered a fresh CI run on the latest branch head, and all checks are now green on this PR.

The previously failing matrix jobs also passed in this run:

  • ms-mf-ng-consul-oauth2-neo4j (n24.14.0/j21)
  • ms-vue-eureka-jwt-couchbase-hazelcast (n24.14.0/j21)

Please let me know if you’d like any follow-up changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant