正式whisper #566
正式whisper #566
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Mrsu9726, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on migrating the application's speech-to-text capabilities from a faster_whisper implementation to the official whisper library, aligning with the intent to use a 'formal' Whisper setup. Accompanying this core change are comprehensive logging enhancements to provide clearer insights into the transcription process and its various stages.
Highlights
- Core Implementation Switch: The primary Whisper implementation has been switched from
faster_whisperto the officialwhisperlibrary. This involves updating default argument values, changing audio decoding functions, and replacing theFasterWhisperInferenceclass withWhisperInferenceacross the codebase. - Deprecation of FasterWhisper: The
FasterWhisperimplementation is being phased out, as evidenced by its removal from various test suites (BGM separation, diarization, transcription, and VAD tests). - Enhanced Logging: Significant logging improvements have been introduced across the transcription pipeline. Detailed
logger.infocalls now provide better visibility into the progress of BGM separation, VAD, transcription, diarization, and file processing. Additionally, a file handler has been added to the logger to write output towebui.log.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request transitions the application to use the official whisper implementation instead of faster-whisper. This involves updating dependencies, modifying default configurations, and adjusting tests. Logging enhancements have been added throughout the codebase to provide more detailed information during processing. The removal of FASTER_WHISPER from the tests and the default configuration are the main changes.
| """ | ||
| start_time = time.time() | ||
|
|
||
| logger.info(f"Run started. audio={audio}") |
There was a problem hiding this comment.
Consider redacting or truncating the audio data in the log message to prevent sensitive information from being exposed. Logging the entire audio content could lead to security vulnerabilities if the logs are compromised.
| logger.info(f"Run started. audio={audio}") | |
| logger.info(f"Run started. audio={'[redacted]' if isinstance(audio, bytes) else audio}") |
| file_handler = logging.FileHandler("webui.log") | ||
| file_handler.setFormatter(formatter) | ||
| logger.addHandler(file_handler) |
There was a problem hiding this comment.
Consider adding a try-except block around the file handler to catch potential exceptions during log file creation or writing. This will prevent the application from crashing if it doesn't have the necessary permissions or if the file is locked.
| file_handler = logging.FileHandler("webui.log") | |
| file_handler.setFormatter(formatter) | |
| logger.addHandler(file_handler) | |
| try: | |
| file_handler = logging.FileHandler("webui.log") | |
| file_handler.setFormatter(formatter) | |
| logger.addHandler(file_handler) | |
| except Exception as e: | |
| print(f"Failed to create or write to log file: {e}") # fallback to console logging |
| "highlight_words": True if params.whisper.word_timestamps else False | ||
| } | ||
|
|
||
| logger.info(f"Transcribing files: {files} input_folder={input_folder_path}") |
There was a problem hiding this comment.
Consider redacting or truncating the files variable in the log message to prevent potentially long file lists from cluttering the logs. A summary or count of files might be more appropriate.
| logger.info(f"Transcribing files: {files} input_folder={input_folder_path}") | |
| logger.info(f"Transcribing files: {len(files) if files else 0} files, input_folder={input_folder_path}") |
|
wrong commit |
1 participant
修改为正式whisper
Related issues / PRs. Summarize issues.
Summarize Changes