Skip to content

Conversation

@EArminjon
Copy link
Contributor

@EArminjon EArminjon commented Sep 19, 2024

options.queryParameters is used by Dio to offer an entrypoint for developpers to give query parameters easily.

options.queryParameters didn't contain queryParameters put inside path string :

Dio().get(
  "https://test.com/home?test=youWillNotSeeMe", 
  queryParameters: {
    "test2: youWillSeeMe",
  },
);

uri.queryParameters contain both (path.queryParameters and options.queryParameters). This PR fix that and this issue : #237

@EArminjon
Copy link
Contributor Author

Hello @jhomlala,

Can you check this PR ? It's very important for us, else we can't use the official latest version

@techouse
Copy link
Collaborator

@EArminjon can you fix your formatting?

@EArminjon
Copy link
Contributor Author

EArminjon commented Nov 10, 2024

@techouse i didn't understand how the format can be wrong :

image

@techouse
Copy link
Collaborator

Yeah, it's weird. Locally all analyzer tests pass. Can you maybe re-run the action?

@techouse
Copy link
Collaborator

techouse commented Nov 10, 2024

Ah, I see. It's an unrelated file packages/alice/lib/ui/calls_list/page/alice_calls_list_page.dart that causes the error.

@EArminjon Can you please run melos format && melos analyze and push all the changes?

@techouse techouse self-requested a review November 10, 2024 11:12
@EArminjon EArminjon force-pushed the fix-dio-query-parameters branch from c8268d4 to e904829 Compare November 10, 2024 11:31
@EArminjon EArminjon force-pushed the fix-dio-query-parameters branch from e904829 to c1574f9 Compare November 10, 2024 11:33
@EArminjon
Copy link
Contributor Author

In final, a rebase was just needed.

OpenfileX used on my branch was the issue : they put a breaking change using 'patch' version instead of 'minor'. Thats lead to the issue above when running pub get. (A nullable string was converted to non nullable)

@techouse techouse merged commit 3311b56 into jhomlala:master Nov 10, 2024
2 checks passed
skeyboy pushed a commit to skeyboy/alice that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants