-
Notifications
You must be signed in to change notification settings - Fork 306
fix-dio-query-parameters #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @jhomlala, Can you check this PR ? It's very important for us, else we can't use the official latest version |
|
@EArminjon can you fix your formatting? |
|
@techouse i didn't understand how the format can be wrong : |
|
Yeah, it's weird. Locally all analyzer tests pass. Can you maybe re-run the action? |
|
Ah, I see. It's an unrelated file @EArminjon Can you please run |
c8268d4 to
e904829
Compare
e904829 to
c1574f9
Compare
|
In final, a rebase was just needed. OpenfileX used on my branch was the issue : they put a breaking change using 'patch' version instead of 'minor'. Thats lead to the issue above when running pub get. (A nullable string was converted to non nullable) |

options.queryParameters is used by Dio to offer an entrypoint for developpers to give query parameters easily.
options.queryParameters didn't contain queryParameters put inside path string :
uri.queryParameterscontain both (path.queryParameters and options.queryParameters). This PR fix that and this issue : #237