Add support for the universal attribute group to transformed elements #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that I did not add the other attributes from the ID attribute group (such as conref or conrefend) as their target needs to match the element name. Since the transformations change the elements, carrying these over does not make much sense to me.
There is no need to test all attributes from the universal attribute group for every single element, I just need to do it once for each topic type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of elements in DITA 1.3 support the universal attribute group which allows the user to assign metadata or a unique ID to these elements. This pull request ensures that the transformed elements retain this universal attribute group whenever possible.
Implementation checklist
python3 -m unittestin the project directory)