Skip to content

Add forms plugin [In progress]#75

Open
markpatton wants to merge 1 commit intomasterfrom
forms
Open

Add forms plugin [In progress]#75
markpatton wants to merge 1 commit intomasterfrom
forms

Conversation

@markpatton
Copy link
Collaborator

@markpatton markpatton commented Jun 30, 2021

This pull request adds the forms plugin to the site.

Note the awkward way some dependency issues with lutece 7 are worked around. Eventually when there is a release, this should be able to be fixed. Another awkwardness (which is not caused by the pr) is that commons_bs4_materialkit.html from lutece-core is overwritten with a version which modified the loaded javascript libraries. At the moment this is required by our 2.2.0 fork of the appointment plugin. The lutece-core macro loads moment at the end of the the page, but this conflicts with the loading order of javascript libraries such as fullcalendar in the appointment plugin. Eventually this should be fixed in a more reasonable way.

There are a number of issues. Some may be caused by problems upstream, some may be problems with our setup.

  • Translation issues: Form management label in menu is “ManageForms” not "Manage Forms". The form editing step needs a bunch of labels translated to English.

  • The forms plugin tries to load the js library toastr from the wrong location. Attempts /js/admin/jquery/plugins/toastr/toastr.min.js but is actually js/jquery/plugins/toastr/toastr.min.js.

  • Attempts to load http://localhost:8080/js/admin/locales/bootstrap-flatpickr..js because the macro to load flatpickr doesn’t handle <@getRegional language=language /> returning an empty string

  • Cannot load /editor.css. Does not exist in war. Cannot load /page_template_styles.css. File exists in /css. The root cause may be ./WEB-INF/templates/admin/plugins/forms/forms_commons.html where <#assign cssFiles="editor.css, page_template_styles.css" />.

  • Cannot select breadcrumb type when trying to make form. There are no option elements in the select. This prevents a form from being created.

  • The forms plugin does not format date and time according to user locale. If that gets fixed, I suspect date and time need to be normalized when being serialized between the database and frontend.

Copy link
Contributor

@jrmartino jrmartino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks straightforward to me - excluding lutece-core version in the plugins seems to be the cleanest way to enforce this version when experimenting with different combinations of plugin versions, possibly having different ideas as to which version of core they like

i'll add that i have already placed a PR on the master branch of this plugin offering some translations / english cleanup suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants