Open
Conversation
jrmartino
reviewed
Jun 30, 2021
Contributor
There was a problem hiding this comment.
looks straightforward to me - excluding lutece-core version in the plugins seems to be the cleanest way to enforce this version when experimenting with different combinations of plugin versions, possibly having different ideas as to which version of core they like
i'll add that i have already placed a PR on the master branch of this plugin offering some translations / english cleanup suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the forms plugin to the site.
Note the awkward way some dependency issues with lutece 7 are worked around. Eventually when there is a release, this should be able to be fixed. Another awkwardness (which is not caused by the pr) is that
commons_bs4_materialkit.htmlfrom lutece-core is overwritten with a version which modified the loaded javascript libraries. At the moment this is required by our 2.2.0 fork of the appointment plugin. The lutece-core macro loads moment at the end of the the page, but this conflicts with the loading order of javascript libraries such as fullcalendar in the appointment plugin. Eventually this should be fixed in a more reasonable way.There are a number of issues. Some may be caused by problems upstream, some may be problems with our setup.
Translation issues: Form management label in menu is “ManageForms” not "Manage Forms". The form editing step needs a bunch of labels translated to English.
The forms plugin tries to load the js library toastr from the wrong location. Attempts
/js/admin/jquery/plugins/toastr/toastr.min.jsbut is actuallyjs/jquery/plugins/toastr/toastr.min.js.Attempts to load
http://localhost:8080/js/admin/locales/bootstrap-flatpickr..jsbecause the macro to load flatpickr doesn’t handle<@getRegional language=language />returning an empty stringCannot load
/editor.css. Does not exist in war. Cannot load/page_template_styles.css. File exists in/css. The root cause may be./WEB-INF/templates/admin/plugins/forms/forms_commons.htmlwhere<#assign cssFiles="editor.css, page_template_styles.css" />.Cannot select breadcrumb type when trying to make form. There are no option elements in the select. This prevents a form from being created.
The forms plugin does not format date and time according to user locale. If that gets fixed, I suspect date and time need to be normalized when being serialized between the database and frontend.