Conversation
movestill
requested changes
Feb 13, 2023
Member
movestill
left a comment
movestill
left a comment
There was a problem hiding this comment.
I think we don't normally want the test files to be installed with the package unless the user specifically asks for them with say pip install ndingest[test]. I'm not sure what that would look like in setup.py but would guess it's doable.
On the AMI, the entire repo is located at: /srv/salt/ndingest/files/ndingest.git/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ndingest is pip installed to the endpoint AMI the tests and test config file for pytest are not copied over.
This PR moves the test directory inside of ndingest. That way they can be tested with the testing script inside of boss-manage/docs