-
Notifications
You must be signed in to change notification settings - Fork 14
Add reproduction for uniffi arc objects #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c5062b9
to
002c0c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a reproduction for uniffi arc objects by adding several test fixtures and updating configurations. Key changes include:
- Adding a TypeScript binding configuration file (uniffi.toml) and new test files in Rust and TypeScript.
- Updating the Rust library implementation and Cargo.toml configurations to support the new test cases.
- Enhancing documentation in the README for running tests and examples.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
fixtures/wasm-arc-futures/uniffi.toml | Adds TypeScript binding settings. |
fixtures/wasm-arc-futures/tests/test_generated_bindings.rs | Introduces a new test file with license header. |
fixtures/wasm-arc-futures/tests/bindings/test_wasm_arc_futures.ts | Provides comprehensive tests for uniffi components. |
fixtures/wasm-arc-futures/tests/bindings/.supported-flavors.txt | Updates supported flavor information. |
fixtures/wasm-arc-futures/src/lib.rs | Implements SimpleObject and associated callback functions. |
fixtures/wasm-arc-futures/README.md | Adds usage instructions and testing documentation. |
fixtures/wasm-arc-futures/Cargo.toml | Modifies dependency configurations for uniffi. |
fixtures/error-types/Cargo.toml | Updates feature flags for uniffi in error types. |
Cargo.toml | Switches uniffi dependency from a fixed version to a git branch reference. |
To run the examples, first `uniffi` must be compiled: | ||
|
||
```sh | ||
$ cargo build --release -p uniffi` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a stray backtick at the end of the cargo build command, which could cause confusion. Consider removing the extra backtick for clarity.
$ cargo build --release -p uniffi` | |
$ cargo build --release -p uniffi |
Copilot uses AI. Check for mistakes.
No description provided.