Remove public access modifier for the TypeScript bindings #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhugman
approved these changes
Dec 15, 2025
Owner
jhugman
left a comment
jhugman
left a comment
There was a problem hiding this comment.
@antonWetzel Thank you so much for your contribution!
I have verified that there are only these template files that use the public modifier.
I will file an issue that building the test-runner has bit rotted.
Author
|
I don't see a button for me to merge this; I am not familiar with the Github UI ^^. Can this be merged by someone else, or is some change wanted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306
This removes the public access modifier for method declarations and the error tag.
Because public is the default modifier, this should not change behavior.
This is only tested with a example project, not the project tests, see notes for details.
Note for tests
macOScmakeandninjald: library 'hermes' not found./scripts/run-tests.sh