Skip to content

Conversation

@istankovic
Copy link

This PR is heavily based on #322, with some differences:

  • it tries to do the minimum work necessary to move to uniffi 0.30
  • lints are unit tests have been fixed

Unfortunately, JSI and WASM tests still fail and I do not know how to fix them.
In particular, the WASM async callbacks test is failing with

error[E0599]: no method named `into_js` found for struct `NonNull<T>` in the current scope
    --> src/async_callbacks_module.rs:1374:61
     |
1374 | ...                   uniffi_out_dropped_callback.into_js(),
     |                                                   ^^^^^^^
     |
help: there is a method `into` with a similar name
     |
1374 -                                 uniffi_out_dropped_callback.into_js(),
1374 +                                 uniffi_out_dropped_callback.into(),
     |

@istankovic istankovic marked this pull request as ready for review December 22, 2025 10:04
@jhugman
Copy link
Owner

jhugman commented Jan 5, 2026

Hey @istankovic Thanks for diving in!

Let me know if there's anything I can do to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants