Review comments

[PhilipOesterlePekrun]

Just some of my changes from the review comments. It took a while for me to figure out how to compile Trilinos with Kokkos CUDA again, but now "use kokkos refactor"...value="true" seems to work on the backends I can test (OpenMP, CUDA), which should be confirmed by the AT2 test.

[github-actions]

CDash for AT1 results [Only accessible from Sandia networks]
CDash for AT2 results [Currently only accessible from Sandia networks]

[github-actions]

Your PR updated files that did not respect package clang formatting settings.
Please apply the patch given below. Alternatively you can download a patch file here.

Patch

diff --git a/packages/muelu/test/tutorial/TutorialDriver.cpp b/packages/muelu/test/tutorial/TutorialDriver.cpp
index 2df4b8ab..f3b9848a 100644
--- a/packages/muelu/test/tutorial/TutorialDriver.cpp
+++ b/packages/muelu/test/tutorial/TutorialDriver.cpp
@@ -86,8 +86,8 @@ int main(int argc, char* argv[]) {
 
       //! [CommunicatorObject begin]
       RCP<const Teuchos::Comm<int>> comm = Teuchos::DefaultComm<int>::getComm();
-      [[maybe_unused]] int MyPID                          = comm->getRank();
-      [[maybe_unused]] int NumProc                        = comm->getSize();
+      [[maybe_unused]] int MyPID         = comm->getRank();
+      [[maybe_unused]] int NumProc       = comm->getSize();
       //! [CommunicatorObject end]
 
       // Instead of checking each time for rank, create a rank 0 stream

More details about our use of clang-format can be found in the wiki.

[github-actions]

Your PR updated files that did not respect package formatting settings.
Please apply the patch given below. Alternatively you can download a patch file here.

Patch

diff --git a/packages/muelu/test/tutorial/TutorialDriver.cpp b/packages/muelu/test/tutorial/TutorialDriver.cpp
index 2df4b8ab..f3b9848a 100644
--- a/packages/muelu/test/tutorial/TutorialDriver.cpp
+++ b/packages/muelu/test/tutorial/TutorialDriver.cpp
@@ -86,8 +86,8 @@ int main(int argc, char* argv[]) {
 
       //! [CommunicatorObject begin]
       RCP<const Teuchos::Comm<int>> comm = Teuchos::DefaultComm<int>::getComm();
-      [[maybe_unused]] int MyPID                          = comm->getRank();
-      [[maybe_unused]] int NumProc                        = comm->getSize();
+      [[maybe_unused]] int MyPID         = comm->getRank();
+      [[maybe_unused]] int NumProc       = comm->getSize();
       //! [CommunicatorObject end]
 
       // Instead of checking each time for rank, create a rank 0 stream

More details about our use of clang-format and other tools can be found in the wiki.

[jhux2]

lgtm