Added explicit setting of FFMPEG install location #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed: def get_encoder_name, get_player_name, get_prober_name Added: detect_binary If FFMPEG is not added to path, there is no way for users to set the FFMPEG location explicitly. This change allows users to do so via environment variables. Unsure if this is the optimal way to achieve this. Note: to work, users must set environment variables before importing pydub
Caused by use of f"..." instead of "...".format (python 2.7 allowed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed: in Utils.py -> get_encoder_name, get_player_name, get_prober_name
Added: in Utils.py -> detect_binary
If FFMPEG is not added to path, there is no way for users to set the FFMPEG location explicitly. This change allows users to do so via environment variables. Unsure if this is the optimal way to achieve this.
Note: to work, users must set environment variables before importing pydub