fix: array item with existing property #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-spacek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
original PR: redhat-developer#882
there is still open discussion if this PR is correct.
I think it is in terms of current implementation. To fix it properly the
findClosestNodehas to be fixed - see the skipped tests in this PR...fix autocompletion when the position is on the same line with the hyphen followed by other props
there are two problems:
Screen.Recording.2023-05-17.at.09.38.41.mov
Screen.Recording.2023-05-17.at.09.39.39.mov
after fix of the 1st problem, the 2nd problem looks like this
Screen.Recording.2023-05-17.at.09.57.23.mov
after fix:
Screen.Recording.2023-05-17.at.09.40.47.mov
UPDATE:
3) this PR also fixes this issue:
Screen.Recording.2023-07-17.at.13.04.06.mov
What issues does this PR fix or reference?
no reference
Is it tested? How?
add unit tests